[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

Since this was committed, all of our internal bots (but not the external windows bot!) are hanging when the tests run. I've looked into it some and I noticed a couple of things:

1. We are *pre*pending to the path, so our existing working setup with gnuwin32 is ignored. I think it would be better to add the paths at the end, so that what already works is not broken.
2. All of the tools that are found along with git (tar.exe, echo.exe, etc.) never return when called in this setup. I am not sure why this is since we have a fairly new version of git and the tools, so they should work correctly, but they don't. This may be a simple update requirement on our part, but if that's the case, the updated documentation should specify what version of git and the tools is required.



================
Comment at: llvm/utils/lit/lit/llvm/config.py:24
-            # For tests that require Windows to run.
-            features.add('system-windows')
-
----------------
Why did you drop this? My understanding is that this is needed in the tests to determine when to run/not run some of them based on the system.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380