[PATCH] D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 2 12:46:26 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:145
+ uint32_t getSectionOrLength32() const {
+ assert(Entry32 && "32-bit interface called on 64-bit object file.");
+ return Entry32->SectionOrLength;
----------------
MaskRay wrote:
> You probably don't need these assert. The dereference will crash anyway
That's not true. There are some number of addressable bytes containing 0 starting from address 0x0 on AIX.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85774/new/
https://reviews.llvm.org/D85774
More information about the llvm-commits
mailing list