[PATCH] D86904: [mlir] Support for defining Types in tblgen

[John Demme via Phabricator via llvm-commits]

jdd added a comment.

As for declaring parse(...), print(...), and getMnemonic() in the header file: these are intended for cases where (for some reason) the dialect doesn't use the global parse/print dispatch method. The dialect could call each parse/print method in its Dialect::parseType/Dialect::printType methods, in concert with the getMnemonic(). I figure even if it's not often used, its just an extra 3 lines in each type declaration.



================
Comment at: mlir/include/mlir/IR/OpBase.td:2364
+
+  // Short summary of the type
+  string summary = ?;
----------------
rriddle wrote:
> nit: Please add proper punctuation to the end of comments.
> 
> There are many cases within the revision still.
Ah. I thought proper punctuation was only necessary after full sentences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86904/new/

https://reviews.llvm.org/D86904