[PATCH] D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Seems fine to me overall.



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1152
   // Check that there is no guard in this block above our instruction.
-  if (!IsSafeToSpeculativelyExecute && ICF->isDominatedByICFIFromSameBlock(LI))
-    return false;
+  bool NeedSafeToSpeculativelyExecute = ICF->isDominatedByICFIFromSameBlock(LI);
+
----------------
This variable name doesn't parse for me.
Perhaps something like `MustEnsureSafetyOfSpeculativeExecutetion`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88725/new/

https://reviews.llvm.org/D88725