[PATCH] D88348: [LLD][COFF] When using LLD-as-a-library, always prevent re-entrance on failures

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 06:24:50 PDT 2020


aganea updated this revision to Diff 295813.
aganea marked 2 inline comments as done.
aganea added a comment.
Herald added a subscriber: pengfei.

Address comments. Removed stdout/stderr buffering, and replace with `env LLD_IN_TEST=1` set appropriately in tests, where needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88348/new/

https://reviews.llvm.org/D88348

Files:
  lld/Common/ErrorHandler.cpp
  lld/include/lld/Common/Driver.h
  lld/test/COFF/arm-thumb-branch20-error.s
  lld/test/COFF/comdat-selection.s
  lld/test/COFF/delayimports-error.test
  lld/test/COFF/driver-windows.test
  lld/test/COFF/driver.test
  lld/test/COFF/export-limit.s
  lld/test/COFF/failifmismatch.test
  lld/test/COFF/invalid-obj.test
  lld/test/COFF/invalid-section-number.test
  lld/test/COFF/linkenv.test
  lld/test/COFF/manifestinput-error.test
  lld/test/COFF/merge.test
  lld/test/COFF/pdata-arm64-bad.yaml
  lld/test/COFF/precomp-link.test
  lld/test/COFF/thin-archive.s
  lld/test/COFF/thunk-replace.s
  lld/tools/lld/lld.cpp
  llvm/include/llvm/Support/CrashRecoveryContext.h
  llvm/include/llvm/Support/Process.h
  llvm/lib/Support/CrashRecoveryContext.cpp
  llvm/lib/Support/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88348.295813.patch
Type: text/x-patch
Size: 19776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201002/75092f22/attachment.bin>


More information about the llvm-commits mailing list