[PATCH] D88660: [AArch64] Add CPU Cortex-R82

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Thanks for reviewing!



================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:310
+  if (std::find(ItBegin, ItEnd, "+v8.4a") != ItEnd ||
+      std::find(ItBegin, ItEnd, "+v8.5a") != ItEnd ||
+      std::find(ItBegin, ItEnd, "+v8.6a") != ItEnd ||
----------------
ostannard wrote:
> SjoerdMeijer wrote:
> > Adding v8.5 and v8.6 here are unrelated changes, but I think they were missed, and I will follow up after this to add tests for this. 
> Please move these (v8.5/6) changes into the patch with the tests.
yeah, cheers, will do.


================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:359
       const bool HasV83a = (std::find(ItBegin, ItEnd, "+v8.3a") != ItEnd);
       const bool HasV84a = (std::find(ItBegin, ItEnd, "+v8.4a") != ItEnd);
       if (!HasSHA2)
----------------
chill wrote:
> This is redundant, because of line 309.
Thanks, I will look at this as a follow up; don't want to touch this monstrosity too much at the same time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88660/new/

https://reviews.llvm.org/D88660