[PATCH] D88725: [GVN LoadPRE] Extend the scope of optimization by using context to prove safety of speculation
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 2 03:49:53 PDT 2020
mkazantsev added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1247
+ if (CriticalEdgePred.size())
+ if (!isSafeToSpeculativelyExecute(LI, LoadBB->getFirstNonPHI(), DT))
+ return false;
----------------
Why is that needed? We split critical edges right below. As far as I understand, we will insert loads into newly created split blocks which is safe.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88725/new/
https://reviews.llvm.org/D88725
More information about the llvm-commits
mailing list