[PATCH] D88660: [AArch64] Add CPU Cortex-R82
Oliver Stannard (Linaro) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 2 03:00:40 PDT 2020
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM, but please split the unrelated change out into a separate patch.
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:310
+ if (std::find(ItBegin, ItEnd, "+v8.4a") != ItEnd ||
+ std::find(ItBegin, ItEnd, "+v8.5a") != ItEnd ||
+ std::find(ItBegin, ItEnd, "+v8.6a") != ItEnd ||
----------------
SjoerdMeijer wrote:
> Adding v8.5 and v8.6 here are unrelated changes, but I think they were missed, and I will follow up after this to add tests for this.
Please move these (v8.5/6) changes into the patch with the tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88660/new/
https://reviews.llvm.org/D88660
More information about the llvm-commits
mailing list