[llvm] b0ce9f0 - [SVE][CodeGen] Fix implicit TypeSize->uint64_t casts in TypePromotion
David Sherwood via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 2 00:17:29 PDT 2020
Author: David Sherwood
Date: 2020-10-02T08:12:11+01:00
New Revision: b0ce9f0f4cff7df243b72e308ec863f012724475
URL: https://github.com/llvm/llvm-project/commit/b0ce9f0f4cff7df243b72e308ec863f012724475
DIFF: https://github.com/llvm/llvm-project/commit/b0ce9f0f4cff7df243b72e308ec863f012724475.diff
LOG: [SVE][CodeGen] Fix implicit TypeSize->uint64_t casts in TypePromotion
The TypePromotion pass only operates on scalar types so I've fixed up
all places where we were relying upon the implicit cast from
TypeSize->uint64_t.
Differential Revision: https://reviews.llvm.org/D88575
Added:
Modified:
llvm/lib/CodeGen/TypePromotion.cpp
Removed:
################################################################################
diff --git a/llvm/lib/CodeGen/TypePromotion.cpp b/llvm/lib/CodeGen/TypePromotion.cpp
index 807babdcaf25..a42095d8718a 100644
--- a/llvm/lib/CodeGen/TypePromotion.cpp
+++ b/llvm/lib/CodeGen/TypePromotion.cpp
@@ -134,8 +134,9 @@ class IRPromoter {
Ctx(C), OrigTy(Ty), PromotedWidth(Width), Visited(visited),
Sources(sources), Sinks(sinks), SafeWrap(wrap) {
ExtTy = IntegerType::get(Ctx, PromotedWidth);
- assert(OrigTy->getPrimitiveSizeInBits() < ExtTy->getPrimitiveSizeInBits()
- && "Original type not smaller than extended type");
+ assert(OrigTy->getPrimitiveSizeInBits().getFixedSize() <
+ ExtTy->getPrimitiveSizeInBits().getFixedSize() &&
+ "Original type not smaller than extended type");
}
void Mutate();
@@ -809,7 +810,7 @@ bool TypePromotion::isLegalToPromote(Value *V) {
bool TypePromotion::TryToPromote(Value *V, unsigned PromotedWidth) {
Type *OrigTy = V->getType();
- TypeSize = OrigTy->getPrimitiveSizeInBits();
+ TypeSize = OrigTy->getPrimitiveSizeInBits().getFixedSize();
SafeToPromote.clear();
SafeWrap.clear();
@@ -980,15 +981,14 @@ bool TypePromotion::runOnFunction(Function &F) {
if (TLI->getTypeAction(ICmp->getContext(), SrcVT) !=
TargetLowering::TypePromoteInteger)
break;
-
EVT PromotedVT = TLI->getTypeToTransformTo(ICmp->getContext(), SrcVT);
- if (RegisterBitWidth < PromotedVT.getSizeInBits()) {
+ if (RegisterBitWidth < PromotedVT.getFixedSizeInBits()) {
LLVM_DEBUG(dbgs() << "IR Promotion: Couldn't find target register "
<< "for promoted type\n");
break;
}
- MadeChange |= TryToPromote(I, PromotedVT.getSizeInBits());
+ MadeChange |= TryToPromote(I, PromotedVT.getFixedSizeInBits());
break;
}
}
More information about the llvm-commits
mailing list