[PATCH] D88697: [WebAssembly] Rename Emscripten EH functions

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 21:37:28 PDT 2020


tlively added a comment.

> There are two occasions that we add a call to `emscripten_longjmp`, but one of them is calling it with an argument type `jmp_buf`. So we need two different signatures, and thus two different functions there.

Would it also work to emit a bitcast of some sort from `jmp_buf` to i32 where that second kind of `emscripten_longjmp` call is generated? If so, would that be simpler overall?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88697/new/

https://reviews.llvm.org/D88697



More information about the llvm-commits mailing list