[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 16:08:19 PDT 2020


myhsu added a comment.

In D88385#2305465 <https://reviews.llvm.org/D88385#2305465>, @rengolin wrote:

> There are plenty of lint checks that need addressing. Some are false positives and those are obvious cases, but the rest should be followed.
>
> You must run clang-format on new files (entirely) and on localised changes of existing files (many editors have the option to select lines and format).

Interesting...the patch I updated yesterday had gone through clang-format. And I didn't see any lint warning here on Phabricator. Maybe I should run again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385



More information about the llvm-commits mailing list