[PATCH] D88339: [XCOFF] Enable -fdata-sections on AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data-sections.ll:36
+}
+
+
----------------
jasonliu wrote:
> jasonliu wrote:
> > hubert.reinterpretcast wrote:
> > > Should the scope cover the constant pool?
> > > 
> > > The output for `llvm/test/CodeGen/PowerPC/aix-lower-constant-pool-index.ll` appears to still use a single `.rodata` csect for items in the constant pool.
> > Summarize offline discussions:
> > It’s actually not trivial to change the constant section emission:
> > This is the function declaration for it:
> > ```
> > MCSection *getSectionForConstant(const DataLayout &DL, SectionKind Kind,
> >                                  const Constant *C,
> >                                  Align &Alignment) const override; 
> > ```
> > There is no existing way to mangle the Constant. And it could be a nullptr for all we know.
> > We could try to roll our own way to mangle a Constant, but at this point, it might not worth the effort.
> I'm planning to land this as is. Let me know if that's okay with you. 
Works for me. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88339/new/

https://reviews.llvm.org/D88339