[PATCH] D88702: [AArch64][GlobalISel] Use emitTestBit in selection for G_BRCOND

[Jessica Paquette via Phabricator via llvm-commits]

paquette created this revision.
paquette added a reviewer: aemerson.
Herald added subscribers: danielkiss, hiraditya, kristof.beyls, rovka.
Herald added a project: LLVM.
paquette requested review of this revision.

Partially refactoring, partially fixing a bug.

- We shouldn't use TB(N)ZX unless the bit number is >= 32 (it has no encoding)
- We can fold more than xor using emitTestBit

Also remove a check which isn't relevant anymore + update tests.

Rename select-brcond-of-not.mir to select-brcond-of-binop.mir, since it now tests more than just G_XOR.


https://reviews.llvm.org/D88702

Files:
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/select-brcond-of-binop.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-brcond-of-not.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select.mir
  llvm/test/CodeGen/AArch64/GlobalISel/widen-narrow-tbz-tbnz.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88702.295671.patch
Type: text/x-patch
Size: 11769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201001/c4accee3/attachment-0001.bin>