[PATCH] D88600: [TableGen] New backend to print fully detailed records

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 12:59:39 PDT 2020


Paul-C-Anagnostopoulos added a comment.

Further investigation reveals that every every backend that prints source locations does not include the line offset. Further, PrintIncludeStack(), in the source manager itself, also does not include the line offset. So I am going to leave this new function without the line offset.

Once this patch is pushed, I will find all those places and change them to use this new function. That cleans away a bunch of uses of lower-level SourceMgr functions.

Then I will ponder what we really want for a universal source file location formatter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88600/new/

https://reviews.llvm.org/D88600



More information about the llvm-commits mailing list