[PATCH] D88677: [AArch64] Match the windows canonical callee saved register order [alternative 3]

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2198
       assert(MFI.getObjectAlign(RPI.FrameIdx) <= Align(16));
       MFI.setObjectAlignment(RPI.FrameIdx, Align(16));
     }
----------------
Both here and at the other call to setObjectAlignment(), maybe add a comment describing what the stack layout actually looks like as a result of the padding? Would help make it clear why the codepaths are separate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88677/new/

https://reviews.llvm.org/D88677