[PATCH] D88678: [LLD][COFF] Fix crash with /summary and PCH input files

Thu Oct 1 10:16:57 PDT 2020

aganea created this revision.
aganea added reviewers: rnk, hans, MaskRay.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
aganea requested review of this revision.

Before this patch /summary was crashing with some .PCH.OBJ files, because `tpiMap[srcIdx++]` was reading at the wrong location. When the TpiSource depends on a .PCH.OBJ file, the types should be offset by the previously merged PCH.OBJ set of indices.

+ at hans since it is a regression from 10.0, but I think we should save it for 11.0.1

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88678

Files:
  lld/COFF/DebugTypes.cpp
  lld/test/COFF/Inputs/precomp2-a.yaml
  lld/test/COFF/Inputs/precomp2.yaml
  lld/test/COFF/precomp-summary-fail.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88678.295611.patch
Type: text/x-patch
Size: 8428 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201001/18a421b2/attachment.bin>