[PATCH] D88641: [AArch64] Omit SEH directives for the epilogue if none are needed

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 10:15:53 PDT 2020


mstorsjo added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1527
   bool IsFunclet = false;
+  bool HasEpilogStart = false;
   auto WinCFI = make_scope_exit([&]() {
----------------
efriedma wrote:
> Not sure the HasEpilogStart boolean is useful here; could you just `assert(HasWinCFI == MF.hasWinCFI())`?  And we shouldn't ever need to call setHasWinCFI().
Right, that'd behave equivalently in the end - will try such a change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88641/new/

https://reviews.llvm.org/D88641



More information about the llvm-commits mailing list