[PATCH] D80367: [RISCV][MC] Print absolute targets of branch instructions
Simon Cook via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 1 09:54:41 PDT 2020
simoncook added a comment.
Thanks for reviewing. I'll rebase and add this shortly.
================
Comment at: llvm/utils/TableGen/CodeGenInstruction.h:89
+ /// PrinterMethodRequiresAddr - The method used to print operands of this
+ /// type requires the program address to print.
----------------
MaskRay wrote:
> "Don’t duplicate function or class name at the beginning of the comment."
>
> https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
Noted. I added this since every other member in this class (except for) Constraints did this, and followed for consistency.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80367/new/
https://reviews.llvm.org/D80367
More information about the llvm-commits
mailing list