[PATCH] D88627: Revert "[AIX] Try to not use LLVM tools while building runtimes"

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D88627#2306231 <https://reviews.llvm.org/D88627#2306231>, @daltenty wrote:

> This actually isn't exclusively a revert of D85329 <https://reviews.llvm.org/D85329> "[AIX] Try to not use LLVM tools while building runtimes" as the title seems to suggest. Before that patch there were already explicit `TOOLCHAIN_TOOLS` specified in the call to `llvm_ExternalProject_Add` in the runtimes build, which already suppressed the target-specific tool selection as mention in the description here.
>
> That said, I'm not opposed to the resulting change, which moves all that logic to one place rather than having an extra layer on top just for the runtimes build. We should clarify the title and description though, because removing the `TOOLCHAIN_TOOLS` here entirely will actually be a new change to how runtimes are built.

Ah, I see what happened here. You'd made your commit initially and then it was reverted. In the meantime, I committed D86366 <https://reviews.llvm.org/D86366> to remove `TOOLCHAIN_TOOLS` entirely from the runtimes build, and then your commit was rebased on top of that and reapplied as rGe03dd978d015 <https://reviews.llvm.org/rGe03dd978d015f6141d14afb3986f39365cabcdab>, which does add the `TOOLCHAIN_TOOLS` back. I'll clarify the description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88627/new/

https://reviews.llvm.org/D88627