[llvm] 7e02bc8 - [NFC][ARM] LowOverheadLoop DEBUG statements

Sam Parker via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 05:38:36 PDT 2020


Author: Sam Parker
Date: 2020-10-01T13:38:16+01:00
New Revision: 7e02bc81c6dad90b0f98f74152f4b0991087d78d

URL: https://github.com/llvm/llvm-project/commit/7e02bc81c6dad90b0f98f74152f4b0991087d78d
DIFF: https://github.com/llvm/llvm-project/commit/7e02bc81c6dad90b0f98f74152f4b0991087d78d.diff

LOG: [NFC][ARM] LowOverheadLoop DEBUG statements

Added: 
    

Modified: 
    llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp b/llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
index ac787a1674ab..d642499833d7 100644
--- a/llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
+++ b/llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
@@ -603,8 +603,10 @@ bool LowOverheadLoop::ValidateTailPredicate() {
     return false;
   }
 
-  if (!VPTState::isValid(RDA))
+  if (!VPTState::isValid(RDA)) {
+    LLVM_DEBUG(dbgs() << "ARM Loops: Invalid VPT state.\n");
     return false;
+  }
 
   if (!ValidateLiveOuts()) {
     LLVM_DEBUG(dbgs() << "ARM Loops: Invalid live outs.\n");
@@ -655,9 +657,13 @@ bool LowOverheadLoop::ValidateTailPredicate() {
   // instructions in the preheader.
   auto CannotInsertWDLSTPBetween = [](MachineBasicBlock::iterator I,
                                       MachineBasicBlock::iterator E) {
-    for (; I != E; ++I)
-      if (shouldInspect(*I))
+    for (; I != E; ++I) {
+      if (shouldInspect(*I)) {
+        LLVM_DEBUG(dbgs() << "ARM Loops: Instruction blocks [W|D]LSTP"
+                   << " insertion: " << *I);
         return true;
+      }
+    }
     return false;
   };
 
@@ -719,11 +725,17 @@ bool LowOverheadLoop::ValidateTailPredicate() {
           continue;
 
         if (isSubImmOpcode(MI->getOpcode())) {
-          if (FoundSub || !IsValidSub(MI, ExpectedVectorWidth))
+          if (FoundSub || !IsValidSub(MI, ExpectedVectorWidth)) {
+            LLVM_DEBUG(dbgs() << "ARM Loops: Unexpected instruction in element"
+                       " count: " << *MI);
             return false;
+          }
           FoundSub = true;
-        } else
+        } else {
+          LLVM_DEBUG(dbgs() << "ARM Loops: Unexpected instruction in element"
+                     " count: " << *MI);
           return false;
+        }
       }
       ToRemove.insert(ElementChain.begin(), ElementChain.end());
     }
@@ -1082,8 +1094,14 @@ void LowOverheadLoop::Validate(ARMBasicBlockUtils *BBUtils) {
     Revert = true;
     return;
   }
-
   TryAdjustInsertionPoint(StartInsertPt, Start, RDA);
+  LLVM_DEBUG(if (StartInsertPt == StartInsertBB->end())
+               dbgs() << "ARM Loops: Will insert LoopStart at end of block\n";
+             else
+               dbgs() << "ARM Loops: Will insert LoopStart at "
+               << *StartInsertPt
+            );
+
   Revert = !ValidateRanges(Start, End, BBUtils, ML);
   CannotTailPredicate = !ValidateTailPredicate();
 }


        


More information about the llvm-commits mailing list