[PATCH] D88577: [AArch64] Generate udot for v16i8 sum reduction to i32

[Vinay Madhusudan via Phabricator via llvm-commits]

mivnay added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10970
+  MachineSDNode *ABD =
+      DAG.getMachineNode(AArch64::UDOTv16i8, SDLoc(Op0), Zeros.getValueType(),
+                         Zeros, Ones, Op0.getOperand(0));
----------------
dmgreen wrote:
> We ideally shouldn't be just producing a machine node here. Can you add a AArch64ISD::UDOT node?
> 
> We should be doing the same for SDOT too.
I have added the support for SDOT.

>  Can you add a AArch64ISD::UDOT node?

Can this be done in a later patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88577/new/

https://reviews.llvm.org/D88577