[PATCH] D88542: [ARM][LowOverheadLoops] Start insertion point

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 01:25:00 PDT 2020


SjoerdMeijer accepted this revision.
SjoerdMeijer added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/mov-operand.ll:32
 ; CHECK-NEXT:    vcvt.f32.u32 s4, s4
+; CHECK-NEXT:    dls lr, r4
 ; CHECK-NEXT:    vdiv.f32 s0, s0, s4
----------------
samparker wrote:
> SjoerdMeijer wrote:
> > Maybe you can help me understanding this a bit better with this example. The DLS has been push down a bit, but I am guessing in this case it doesn't really matter?
> > Which kind of leads me to my more general question(s): is this an optimisation, or a bug fix, and which test case is the best to look at it?
> It doesn't really matter for these examples, this patch is just a precursor for improving the tail predication version (since we really don't want any instructions after LSTP in the preheader).
Ok, cheers, in that case LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88542/new/

https://reviews.llvm.org/D88542



More information about the llvm-commits mailing list