[PATCH] D88389: [M68K] (Patch 3/8) Basic infrastructures and changes on object file encoding

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 23:15:49 PDT 2020


lebedev.ri added a comment.

In D88389#2299450 <https://reviews.llvm.org/D88389#2299450>, @myhsu wrote:

> In D88389#2297378 <https://reviews.llvm.org/D88389#2297378>, @lebedev.ri wrote:
>
>> Please can you extract google benchmark change into a separate patch/review,
>> and additionally submit it upstream (https://github.com/google/benchmark)?
>> I'll merge it speedily there.
>
> Thank you! I'd just filed the PR: https://github.com/google/benchmark/pull/1050
> Just curious, should i remove the corresponding changes in this patch? Or should I open up another Phabricator review that only contains the (google benchmark) change?

Thanks. Latter, please open a new review for just that change.
See D78084 <https://reviews.llvm.org/D78084> for a template of what needs to be done - there are 3 (three) copies of `benchmark`: in llvm, in libcxx, and in test-suite (latter is a standalone repo),
when patching each one, please update it's README.LLVM to document that patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389



More information about the llvm-commits mailing list