[PATCH] D87154: [WIP][Statepoints] Change statepoint machine instr format to better suit VReg lowering.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: llvm/lib/CodeGen/FixupStatepointCallerSaved.cpp:373
+    SmallSet<Register, 8> GCRegs;
+    // With new statepoint format, all GC pointer operands assigned to
+    // registers produce new value. Since they're tied to their defs,
----------------
in a time - "new" will become not a new :)
I would propose something like:
  Due to statepoint format, ...


================
Comment at: llvm/lib/CodeGen/StackMaps.cpp:372
 
+void StackMaps::parseStatepointOpers(const MachineInstr &MI,
+                                     MachineInstr::const_mop_iterator MOI,
----------------
Does it makes sense to document statepoint format here in comment?
Or may be provide a link to place where it is documented?


================
Comment at: llvm/lib/CodeGen/StackMaps.cpp:457
   // Parse operands.
-  while (MOI != MOE) {
-    MOI = parseOperand(MOI, MOE, Locations, LiveOuts);
+  if (MI.getOpcode() == TargetOpcode::STATEPOINT) {
+    parseStatepointOpers(MI, MOI, MOE, Locations, LiveOuts);
----------------
now you can remove redundant {}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87154/new/

https://reviews.llvm.org/D87154