[PATCH] D81689: [WebAssembly] New-style command support

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

The description needs updating to reflect the fact that this change no longer adds the `--emscripten` flag.



================
Comment at: lld/test/wasm/command-exports-no-tors.s:8
+
+	.section	.text.foo_i32,"",@
+	.globl	foo_i32
----------------
You can remove the `.section` directives for all functions I believe to make the tests most concise.


================
Comment at: lld/test/wasm/command-exports-no-tors.s:10
+	.globl	foo_i32
+	.type	foo_i32, at function
+foo_i32:
----------------
And these explicit `.type` entries for functions.   (the .functype on its own below I think is enough).


================
Comment at: lld/test/wasm/command-exports-no-tors.s:18
+.Lfunc_end0:
+	.size	foo_i32, .Lfunc_end0-foo_i32
+
----------------
And these two lines can go too.


================
Comment at: lld/test/wasm/command-exports.s:94
+	.int32	.Lregister_call_dtors.1
+	.weak	__dso_handle
+	.export_name	foo_i32, foo_i32
----------------
No need for `__dso_handle` here or above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81689/new/

https://reviews.llvm.org/D81689