[PATCH] D88438: BreakCriticalEdges: bail if loop-simplify form requested for CallBr terminated BB
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 30 16:51:59 PDT 2020
nickdesaulniers added a comment.
In D88438#2304941 <https://reviews.llvm.org/D88438#2304941>, @void wrote:
> I believe that a critical edge may be split on the default path, but not the indirect path.
I don't think https://github.com/llvm/llvm-project/commit/2fe457690da0fc38bc7f9f1d0aee2ba6a6a16ada made a similar distinction?
I think if I add a `bool CallBrInst::isIndirectDest(BasicBlock&);` method, I would be able to use that here and in the above cases linked without regressing the test case added in the above link.
The concept of splitting a critical edge is still relatively new to me; any thoughts on *why* it would not be ok to split a critical branch of an indirect-like jump?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88438/new/
https://reviews.llvm.org/D88438
More information about the llvm-commits
mailing list