[PATCH] D88432: [InstCombine] Fix pr47668

Juneyoung Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 15:14:09 PDT 2020


aqjune added a comment.

In D88432#2298717 <https://reviews.llvm.org/D88432#2298717>, @lebedev.ri wrote:

> - if the shift amount is a variable, check that it is not undef
> - if it is a constant, sanitize undef elts to 0

In the first case, the variable should be checked to be less than the bitwidth as well, which is slightly expensive so not contained in this patch.

The second case is what this change contains. Additionally, it had to check whether the value was less than the bitwidth, which made the code slightly longer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88432/new/

https://reviews.llvm.org/D88432



More information about the llvm-commits mailing list