[PATCH] D88615: [XCOFF] Enable explicit sections on AIX
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 30 14:28:35 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:673
+ if (ExistedEntry->isMultiSymbolsAllowed() != MultiSymbolsAllowed)
+ report_fatal_error("section's multiply symbols policy does not match");
+
----------------
Maybe it's worth to discuss: is there a better way to detect and prevent this case from happening?
```
int b __attribute__((section("a"))) = 2;
int a = 3;
```
Right now, I have to add a new field to MCSectionXCOFF to see if the policy matches. Not sure if we could do it without this new field.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88615/new/
https://reviews.llvm.org/D88615
More information about the llvm-commits
mailing list