[PATCH] D88543: [AArch64] Match the windows canonical callee saved register order

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2018
+    if (N % 2 != 0)
+      return true;
+  } else if (Reg1 == AArch64::FP && Reg2 == AArch64::LR) {
----------------
This if ends up being a little confusing to read... maybe worth duplicating the `if (Reg2 == Reg1 + 1)` check into both the integer and fp branches of the if statement.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:2211
+      bool DoFixup = false;
+      if (!NeedsWinCFI) {
+        DoFixup = !RPI.isPaired();
----------------
Do we really need to check NeedsWinCFI here?  It seems like the rounding should be a property of the chosen stack layout, which should already be determined at this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88543/new/

https://reviews.llvm.org/D88543