[PATCH] D88493: [XCOFF] Use -data-sections=true as default for llc on AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

@jasonliu: There's a lot of test adjustments to explicitly use the non-default, but I am not sure there is testing here to validate that the `llc` default when producing XCOFF assembly/object output is with unique data sections.



================
Comment at: llvm/lib/CodeGen/CommandFlags.cpp:481
   Options.DataSections = getDataSections();
+  Options.ExplicitDataSections = getExplicitDataSections().hasValue();
   Options.FunctionSections = getFunctionSections();
----------------
Suggestion (see proposed edit).

Not sure if the suggested name is better. Just noting that is particular line doesn't fit the pattern for when there is a `codegen::get*` function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88493/new/

https://reviews.llvm.org/D88493