[PATCH] D88340: Patch IEEEFloat::isSignificandAllZeros and IEEEFloat::isSignificandAllOnes (bug 34579)

[Andrew Briand via Phabricator via llvm-commits]

andrewbriand added inline comments.


================
Comment at: llvm/lib/Support/APFloat.cpp:845
   const integerPart *Parts = significandParts();
   const unsigned PartCount = partCount();
+
----------------
craig.topper wrote:
> Does the original code just work if we change this line to "unsigned PartCount = partCountForBits(semantics->precision)"? That will calculate the part count without the guard bit.
Yes, that does work. I've updated the patch accordingly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88340/new/

https://reviews.llvm.org/D88340