[PATCH] D86071: [MLIR][OpenMP] Add omp.wsloop operation

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:103
+
+def WsLoopOp : OpenMP_Op<"wsloop", [AttrSizedOperandSegments]> {
+  let summary = "workshare loop construct";
----------------
Would it make sense to add the `DeclareOpInterfaceMethods<LoopLikeOpInterface>` trait since you added `lowerBound`, `upperBound` and `step`? 


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:106
+  let description = [{
+    The workshare loop construct specifies that the iterations of the associated
+    loops will be executed in parallel by threads in the current context. These
----------------
Since it is now a loop should the `associated loops` be rephrased? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86071/new/

https://reviews.llvm.org/D86071