[PATCH] D82588: [DSE] Look through memory PHI arguments when removing noop stores in MSSA.

[Zoe Carver via Phabricator via llvm-commits]

zoecarver added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/simple-todo.ll:8
+; Remove both redundant stores if loaded value is in another block inside a loop.
+define i32 @test47(i1 %c, i32* %p, i32 %i) {
+; CHECK-LABEL: @test47(
----------------
fhahn wrote:
> IIUC we should now handle the original case correctly? Can you move it to `simple.ll` and perhaps add the additional case to `noop-stores.ll`?
Original case? Do you mean `test31`? I've added that to `noop-stores.ll`. Also, what do you mean by the additional case? `test47`? 

`test47` we don't yet support but it's a pretty simple fix, I think we can just check if the def is a `StoreInst` and run it through `storeIsNoop` and if that returns true we can continue instead of returning false. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82588/new/

https://reviews.llvm.org/D82588