[PATCH] D88593: [DebugInfo] Add tests for ISel handling of variadic debug values

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 10:10:50 PDT 2020


StephenTozer created this revision.
StephenTozer added reviewers: aprantl, djtodoro, vsk, dblaikie, probinson.
StephenTozer added a project: debug-info.
Herald added subscribers: llvm-commits, ormris.
Herald added a project: LLVM.
StephenTozer requested review of this revision.

This patch concludes the implementation of ISel support for multi-location-operand debug values, simply adding a set of lit tests. The reason these tests are put into a separate patch to the implementation is because all of these tests depend on the complete implementation, but there are two separate patches that complete the implementation and do not depend on each other (one for reading and processing dbg.values, the other for emitting DBG_VALUE_LIST instructions). Adding any of these tests to either of those patches could be misleading, as the tests would not pass within that patch (they would require the other).

If this is a confusing or difficult-to-read patch layout as a result however, I'm happy to move these tests into one of the other patches and make that patch dependent on the other.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88593

Files:
  llvm/test/DebugInfo/X86/arg-dbg-value-list.ll
  llvm/test/DebugInfo/X86/dbg-val-list-dangling.ll
  llvm/test/DebugInfo/X86/dbg-val-list-undef.ll
  llvm/test/DebugInfo/X86/dbg-value-list-dag-combine.ll
  llvm/test/DebugInfo/X86/dbg-value-list-selectiondag-salvage.ll
  llvm/test/DebugInfo/X86/debug_value_list_selectiondag.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88593.295339.patch
Type: text/x-patch
Size: 20168 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/e901bfa5/attachment.bin>


More information about the llvm-commits mailing list