[PATCH] D88523: scudo: Make it thread-safe to set some runtime configuration flags.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/options.h:1
+#pragma once
+
----------------
cryptoad wrote:
> LLVM header is missing
> Also I used a #ifdef construct in all the other .h, so maybe keep that or consistency? Or eventually move them all to a pragma if it works everywhere.
Oops, this was meant to start like all the other files (I used pragma once to start with out of laziness, then forgot to fix it before uploading). Fixed now.

I'm not actually sure why we don't use pragma once in LLVM since it's supported by all of the compilers that we support. I guess it may be something like "don't make it gratuitously difficult to build with a compiler that doesn't support it". At any rate I'll leave the situation as is for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88523/new/

https://reviews.llvm.org/D88523