[PATCH] D88339: [XCOFF] Enable -fdata-sections on AIX

[David Tenty via Phabricator via llvm-commits]

daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data-sections.ll:47
+; CHECK-NEXT:         .csect .rodata.str1.1L...str[RO],2
+; CHECK-NEXT:         .byte   97
+; CHECK-NEXT:         .byte   98
----------------
Note that this might be changed by D80953


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-data-sections.ll:78
+; CHECKOBJ-NEXT:  0000003c <.rodata.str1.1L...str>:
+; CHECKOBJ-NEXT:        3c: 61 62 63 64   ori 2, 11, 25444
+; CHECKOBJ-NEXT:        40: 65 66 67 68   oris 6, 11, 26472
----------------
nit: I think we could drop the instruction decode from the check since it's not meaningful and we're actually only testing the raw data


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88339/new/

https://reviews.llvm.org/D88339