[PATCH] D88523: scudo: Make it thread-safe to set some runtime configuration flags.

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 08:34:14 PDT 2020


cryptoad accepted this revision.
cryptoad added a comment.
This revision is now accepted and ready to land.

LGTM with comment



================
Comment at: compiler-rt/lib/scudo/standalone/options.h:1
+#pragma once
+
----------------
LLVM header is missing
Also I used a #ifdef construct in all the other .h, so maybe keep that or consistency? Or eventually move them all to a pragma if it works everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88523/new/

https://reviews.llvm.org/D88523



More information about the llvm-commits mailing list