[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 07:19:52 PDT 2020


aeubanks added inline comments.


================
Comment at: llvm/test/CodeGen/Hexagon/registerpassbuildercallbacks.ll:6
+; Function Attrs: noinline nounwind optnone
+define dso_local void @foo() {
+entry:
----------------
quic_aankit wrote:
> aeubanks wrote:
> > How did you come up with this IR?
> > 
> > I've typically seen something like the IR in llvm/test/Other/new-pm-defaults.ll to test this sort of stuff.
> I generated the .ll through C source file.
> 
> Is it better to add the testcase to llvm/test/Other/new-pm-defaults.ll itself?
I think copying that here would be better rather than using something generated by clang. That IR was specifically constructed for this sort of test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88138/new/

https://reviews.llvm.org/D88138



More information about the llvm-commits mailing list