[PATCH] D86511: [GlobalISel] Fix incorrect setting of ValNo when splitting

Gabriel Hjort Ã…kerlund via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 07:08:38 PDT 2020


ehjogab updated this revision to Diff 295268.
ehjogab added a comment.

Rebased to latest (forgot to pull)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86511/new/

https://reviews.llvm.org/D86511

Files:
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp


Index: llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
+++ llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
@@ -285,7 +285,7 @@
           }
           Args[i].Regs.push_back(Reg);
           Args[i].Flags.push_back(Flags);
-          if (Handler.assignArg(i + Part, NewVT, NewVT, CCValAssign::Full,
+          if (Handler.assignArg(i, NewVT, NewVT, CCValAssign::Full,
                                 Args[i], Args[i].Flags[Part], CCInfo)) {
             // Still couldn't assign this smaller part type for some reason.
             return false;
@@ -318,7 +318,7 @@
         }
         Args[i].Regs.push_back(Unmerge.getReg(PartIdx));
         Args[i].Flags.push_back(Flags);
-        if (Handler.assignArg(i + PartIdx, NewVT, NewVT, CCValAssign::Full,
+        if (Handler.assignArg(i, NewVT, NewVT, CCValAssign::Full,
                               Args[i], Args[i].Flags[PartIdx], CCInfo))
           return false;
       }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86511.295268.patch
Type: text/x-patch
Size: 1039 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/89a32140/attachment.bin>


More information about the llvm-commits mailing list