[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

I looked over all intrinsics again, 3 times I think we should opt-out. The tests look good. I'll send another reminder email because people need to update their target intrinsics as we move over.

LGTM with the nits below



================
Comment at: llvm/include/llvm/IR/Intrinsics.td:359
 
+class DefaultIntrinsic<list<LLVMType> ret_types,
+                list<LLVMType> param_types = [],
----------------
Add a comment here describing the difference to the class above.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:981
                                       [IntrReadMem, IntrArgMemOnly]>,
                                       GCCBuiltin<"__builtin_adjust_trampoline">;
 
----------------
Opt out for these 2


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1167
                                              [IntrReadMem, ImmArg<ArgIndex<1>>,
                                               ImmArg<ArgIndex<2>>]>;
 
----------------
Opt out for these 3


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1238
 def int_debugtrap : Intrinsic<[]>,
                     GCCBuiltin<"__builtin_debugtrap">;
 
----------------
Make this Default too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86021/new/

https://reviews.llvm.org/D86021