[PATCH] D88501: [asan][test] Several Posix/unpoison-alternate-stack.cpp fixes
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 30 07:03:39 PDT 2020
ro marked an inline comment as done.
ro added inline comments.
================
Comment at: compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp:89
- struct sigaction Action = {
- .sa_sigaction = signalHandler,
- .sa_flags = SA_SIGINFO | SA_NODEFER | SA_ONSTACK,
- };
+ struct sigaction Action;
+ Action.sa_sigaction = signalHandler;
----------------
vitalybuka wrote:
>
This doesn't compile on Linux/x86_64:
```
/vol/llvm/src/llvm-project/local/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp:89:3: error: must use 'struct' tag to refer to type 'sigaction' in this scope
sigaction Action = {};
^
struct
```
Will go for
```
struct sigaction Action = {};
```
instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88501/new/
https://reviews.llvm.org/D88501
More information about the llvm-commits
mailing list