[PATCH] D88502: [llvm][Support] Delete unused is_absolute_gnu helper

Kadir Cetinkaya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 04:45:01 PDT 2020


kadircet added a reviewer: tinti.
kadircet added a subscriber: tinti.
kadircet added a comment.

Hi @tinti this code seems to be recently introduced without any usage, and as pointed out by @certl it doesn't consider multi-byte drive letters.

Are you planning to add any usages to the helper? If so, please consider Christopher's points about potential problems.
If you are not planning to add any usages, I beleive it would be best to delete the helper to reduce confusion.

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88502/new/

https://reviews.llvm.org/D88502



More information about the llvm-commits mailing list