[PATCH] D88488: [llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 01:25:58 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-got.test:9-11
+# RUN: llvm-readobj -A %t.got.o 2>&1 | FileCheck %s -DOTHERNUM=0 -check-prefix=BASIC
+# RUN: llvm-readobj -A %t.got.so 2>&1 | FileCheck %s -DOTHERNUM=0 -check-prefix=BASIC
+# RUN: llvm-readobj -A %t.got.exe 2>&1 | FileCheck %s -DOTHERNUM=0 -check-prefix=BASIC
----------------
jhenderson wrote:
> Maybe for consistency the prefix should be BASIC-LLVM. Same below.
Fixed. Does the rest LG to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88488/new/

https://reviews.llvm.org/D88488



More information about the llvm-commits mailing list