[PATCH] D88401: [lib/Support/CommandLine][windows] - Handle "\ " as a space token.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 01:09:54 PDT 2020


jhenderson added a comment.

In D88401#2301151 <https://reviews.llvm.org/D88401#2301151>, @rnk wrote:

> In D88401#2300007 <https://reviews.llvm.org/D88401#2300007>, @jhenderson wrote:
>
>> That being said, since LLD is supposed to be GNU compatible, it would make sense if it matched the GNU behaviour.
>
> I'm agreed on all fronts, but the above statement makes me twitch a bit, lld-link does not strive to be GNU compatible. :) But yes, generally, many parts of LLD aim to be GNU-compatible. We probably just need to more carefully nail down the conditions under which GNU response file parsing is desired. I believe the user always the escape hatch of `--rsp-quoting=posix/windows`.

That's fair - you can tell which version of LLD I use most often :-) Using `--rsp-quoting=windows` is probably a good enough escape hatch for those working with cross-platform toolchains, as long as we let people know this will be coming (i.e. we should release note this behaviour change).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88401/new/

https://reviews.llvm.org/D88401



More information about the llvm-commits mailing list