[PATCH] D88293: [ControlDependentDCE] Add Control Dependent DCE pass

Masaki Arai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 22:01:52 PDT 2020


masakiarai updated this revision to Diff 295171.
masakiarai added a comment.

In D88293#2295161 <https://reviews.llvm.org/D88293#2295161>, @masakiarai wrote:

> Test duplicate-conditional.ll succeeds in my local build.
> I will investigate this as it may be a severe bug.

I fixed this bug and updated the patch.

The cause of the bug was referencing an uninitialized variable, which was in the code copied from JumpThreading pass did not adequately incorporate its update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88293/new/

https://reviews.llvm.org/D88293

Files:
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/LinkAllPasses.h
  llvm/include/llvm/Transforms/Scalar.h
  llvm/include/llvm/Transforms/Scalar/ControlDependentDCE.h
  llvm/lib/LTO/LTOCodeGenerator.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
  llvm/lib/Transforms/Scalar/CMakeLists.txt
  llvm/lib/Transforms/Scalar/ControlDependentDCE.cpp
  llvm/lib/Transforms/Scalar/Scalar.cpp
  llvm/test/Transforms/ControlDependentDCE/conditional-to-unconditional.ll
  llvm/test/Transforms/ControlDependentDCE/duplicate-conditional.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88293.295171.patch
Type: text/x-patch
Size: 63873 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200930/18795768/attachment.bin>


More information about the llvm-commits mailing list