[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 19:01:18 PDT 2020


jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/utils/TableGen/CodeBeadsGen.cpp:9
+//===----------------------------------------------------------------------===//
+// TODO add description
+//===----------------------------------------------------------------------===//
----------------
This needs to be filled in before landing.


================
Comment at: llvm/utils/TableGen/TableGen.cpp:26
   GenEmitter,
+  GenCodeBeads,
   GenRegisterInfo,
----------------
I don't understand what order these are in, so why here rather than at the end of the enum?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385



More information about the llvm-commits mailing list