[PATCH] D88405: [LiveDebugValues][InstrRef][1/2] Try harder to recover clobbered variable locations

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 16:45:08 PDT 2020


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1139
+  void clobberMloc(LocIdx MLoc, MachineBasicBlock::iterator Pos,
+                   bool make_undef = true) {
     auto ActiveMLocIt = ActiveMLocs.find(MLoc);
----------------
this seems to be always called with `false`? Does that mean the second half is untested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88405/new/

https://reviews.llvm.org/D88405



More information about the llvm-commits mailing list