[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

Alan Phipps via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 15:11:22 PDT 2020


alanphipps added a comment.

In D84467#2264205 <https://reviews.llvm.org/D84467#2264205>, @vsk wrote:

> @alanphipps thanks for bearing with me. I think this is about ready to land. I do ask that you back out any punctuation/whitespace changes in code/tests that aren't directly modified in your diff (the clang-format-diff script can help with this). It looks like some libCoverage and test changes are no longer in the current version of this patch, as compared to the previous version (https://reviews.llvm.org/D84467?id=287269). Was that intentional?

I apologize for the long delay myself -- I think I discovered a bug in the code that I'm trying to work out.  In answer to your question about the patches, no it wasn't intentional; I believe I produced the patch incorrectly, only capturing the most recent changes.  I'll update this soon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84467/new/

https://reviews.llvm.org/D84467



More information about the llvm-commits mailing list