[PATCH] D88238: [APFloat] convert SNaN to QNaN in convert() and raise Invalid signal

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 14:12:47 PDT 2020


efriedma added a comment.

> So unless there's a way to raise opInvalidOp without also creating a NaN, we're stuck?

Maybe you can divide by zero?  Otherwise, I agree, we can't split this into a separate patch.

But in any case, we should have some test coverage outside the MIPS-specific testcases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88238/new/

https://reviews.llvm.org/D88238



More information about the llvm-commits mailing list