[PATCH] D88506: [lld][WebAssembly] Allow exporting of mutable globals

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

In D88506#2301679 <https://reviews.llvm.org/D88506#2301679>, @tlively wrote:

> I think it's kind of confusing that export-all doesn't actually export all the symbols. What if we instead made export-all exactly equivalent to individually exporting all the symbols so that it errors out if mutable-globals is not enabled and any of the symbols is a mutable global? Then we could add a `--no-export=<symbol>` flag that users or drivers could use to filter out the mutable global symbols if they can't enable mutable-globals and need to avoid the error.

The problem with that is that it would be breaking change for pretty much all current users of `--export-all`.     This is not ideal... but I think its reasonable compromise between internal consistency and backward compatibility.

Also its not clear that any users of `--export-all` really want these internal symbols to be exported.  Indeed they have made do up until now without them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88506/new/

https://reviews.llvm.org/D88506